Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects the config-store handling for not-found errors #5203

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Corrects the config-store handling for not-found errors #5203

merged 2 commits into from
Apr 12, 2023

Conversation

davidporter-id-au
Copy link
Contributor

What changed?

  • Swaps the config-store to use the DB plugin checker for not-found entries rather than doing a direct error comparison. This makes it compatible with internal forks of goCQL

Why?

How did you test it?
Unit-tests, manual-tests. However, given this error it's probably not been tested extensively.

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au marked this pull request as ready for review April 12, 2023 20:05
@coveralls
Copy link

coveralls commented Apr 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 01877728-a214-49ff-a83b-fc8cc001c7c1

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.08%) to 57.189%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosqlConfigStore.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/task/transfer_standby_task_executor.go 2 87.24%
service/history/task/fetcher.go 4 91.24%
service/history/queue/timer_queue_processor_base.go 7 77.48%
service/history/execution/mutable_state_task_refresher.go 8 66.77%
Totals Coverage Status
Change from base Build 01876c66-a3be-4e17-91b5-e14f7457e2fa: 0.08%
Covered Lines: 85413
Relevant Lines: 149351
💛 - Coveralls

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) April 12, 2023 20:51
@davidporter-id-au davidporter-id-au merged commit eade936 into uber:master Apr 12, 2023
@davidporter-id-au davidporter-id-au deleted the bugfix/correct-config-store branch April 12, 2023 21:00
davidporter-id-au added a commit that referenced this pull request Apr 12, 2023
@davidporter-id-au
Squashed commit of the following:
7c43497 
commit eade936
Author: David Porter <david.porter@uber.com>
Date:   Wed Apr 12 13:54:13 2023 -0700

    Corrects the config-store handling for not-found errors (#5203)

commit 9fc4485
Author: lancezhao-ins <99238165+lancezhao-ins@users.noreply.github.com>
Date:   Tue Apr 11 04:21:15 2023 +1000

    Allow registering search attributes without Advance Visibility enabled (#5185)

    * remove validation & test for add search attribute with no advanced config

    - Remove validation for Advance Visibility Store
    - Add Advance Visibility Config check before update ElasticSearch/OpenSearch mapping
    - Remove co-related test for 'no advanced config'

    * Update CHANGELOG.md

    Update CHANGELOG.md

    * Add warn level message if skip updating OpenSearch/ElasticSearch mapping

    * Add warn level message and add validSearchAttributes in development.yaml

    ---------

    Co-authored-by: Quanzheng Long <prclqz@gmail.com>

commit d165c7b
Author: neil-xie <104041627+neil-xie@users.noreply.github.com>
Date:   Mon Apr 10 10:46:04 2023 -0700

    Update idls version (#5200)

commit b2bc8bf
Author: Mantas Šidlauskas <mantass@netapp.com>
Date:   Mon Apr 10 20:12:53 2023 +0300

    Add thin ES clients (#5162)

    * Add thin ES clients
davidporter-id-au added a commit that referenced this pull request Apr 13, 2023
@davidporter-id-au
Squashed commit of the following:
d7d1116 
commit eade936
Author: David Porter <david.porter@uber.com>
Date:   Wed Apr 12 13:54:13 2023 -0700

    Corrects the config-store handling for not-found errors (#5203)

commit 9fc4485
Author: lancezhao-ins <99238165+lancezhao-ins@users.noreply.github.com>
Date:   Tue Apr 11 04:21:15 2023 +1000

    Allow registering search attributes without Advance Visibility enabled (#5185)

    * remove validation & test for add search attribute with no advanced config

    - Remove validation for Advance Visibility Store
    - Add Advance Visibility Config check before update ElasticSearch/OpenSearch mapping
    - Remove co-related test for 'no advanced config'

    * Update CHANGELOG.md

    Update CHANGELOG.md

    * Add warn level message if skip updating OpenSearch/ElasticSearch mapping

    * Add warn level message and add validSearchAttributes in development.yaml

    ---------

    Co-authored-by: Quanzheng Long <prclqz@gmail.com>

commit d165c7b
Author: neil-xie <104041627+neil-xie@users.noreply.github.com>
Date:   Mon Apr 10 10:46:04 2023 -0700

    Update idls version (#5200)

commit b2bc8bf
Author: Mantas Šidlauskas <mantass@netapp.com>
Date:   Mon Apr 10 20:12:53 2023 +0300

    Add thin ES clients (#5162)

    * Add thin ES clients

Merge issue
davidporter-id-au added a commit that referenced this pull request Apr 19, 2023
@davidporter-id-au
Squashed commit of the following:
c405734 
commit b18be27
Author: Mantas Šidlauskas <mantass@netapp.com>
Date:   Tue Apr 18 14:12:09 2023 +0300

    Add generic ES query building utilities (#5168)

commit 824f0ac
Author: agautam478 <72432016+agautam478@users.noreply.github.com>
Date:   Fri Apr 14 13:37:29 2023 -0700

    Fixed the nil pointer issues in the InactiveDomain Invariant (#5213)

commit c5678dd
Author: Ketsia <115650494+ketsiambaku@users.noreply.github.com>
Date:   Wed Apr 12 15:21:10 2023 -0700

    Fix consistent query metric (#5170)

    * add shardid tag to log

    * remove counter for overall scope

    * fix lint

commit eade936
Author: David Porter <david.porter@uber.com>
Date:   Wed Apr 12 13:54:13 2023 -0700

    Corrects the config-store handling for not-found errors (#5203)

commit 9fc4485
Author: lancezhao-ins <99238165+lancezhao-ins@users.noreply.github.com>
Date:   Tue Apr 11 04:21:15 2023 +1000

    Allow registering search attributes without Advance Visibility enabled (#5185)

    * remove validation & test for add search attribute with no advanced config

    - Remove validation for Advance Visibility Store
    - Add Advance Visibility Config check before update ElasticSearch/OpenSearch mapping
    - Remove co-related test for 'no advanced config'

    * Update CHANGELOG.md

    Update CHANGELOG.md

    * Add warn level message if skip updating OpenSearch/ElasticSearch mapping

    * Add warn level message and add validSearchAttributes in development.yaml

    ---------

    Co-authored-by: Quanzheng Long <prclqz@gmail.com>

commit d165c7b
Author: neil-xie <104041627+neil-xie@users.noreply.github.com>
Date:   Mon Apr 10 10:46:04 2023 -0700

    Update idls version (#5200)

commit b2bc8bf
Author: Mantas Šidlauskas <mantass@netapp.com>
Date:   Mon Apr 10 20:12:53 2023 +0300

    Add thin ES clients (#5162)

    * Add thin ES clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidporter-id-au @coveralls @Shaddoll