Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #24

Closed
jogly opened this issue Jan 14, 2020 · 0 comments
Closed

Support Go Modules #24

jogly opened this issue Jan 14, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jogly
Copy link
Collaborator

jogly commented Jan 14, 2020

https://blog.golang.org/v2-go-modules

I will add a v3 module with a patch version bump to comply with the go modules pattern. This will not break existing users, with or without go modules, because go module users will have to opt-in to using the new github.com/uber/h3-go/v3 import path.

plan for future development

all changes and improvements to v3.* will be made in the v3/ module, leaving the root module as-is. Users of the root module will need to move to the GOMODULE supported /v3 suffix import (github.com/uber/h3-go/v3) to pick up any changes/fixes introduced after v3.0.2.

rationale

future development will be made in the v3 module and not reflected in the root module in order to avoid copy/paste mistakes. Developing in the v3 module will also encourage adoption of the backwards compatible development practices encouraged by GOMODULES.

jogly pushed a commit that referenced this issue Jan 14, 2020
This repo follows a modified version of semver, where the major version
of this repository tracks the major version of the C core repository.
This doesn't play well with GOMODULES by default, so we create our first
major version go module that is just a duplication of master version.

Solves #24
@jogly jogly added the enhancement New feature or request label Jan 15, 2020
jogly pushed a commit that referenced this issue Feb 28, 2020
* add support for GOMODULES

This repo follows a modified version of semver, where the major version
of this repository tracks the major version of the C core repository.
This doesn't play well with GOMODULES by default, so we create our first
major version go module that is just a duplication of master version.

Solves #24
@jogly jogly closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant