-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated h3 core to 3.4.0 and updated tests #13
Conversation
@squiidz thanks for the update. quickly scrolling through, I only see one go test file is modified. Have you only had to run |
@bsr203 yes, I changed the version in H3_VERSION and used |
Thanks for your contribution. Please note that @joegilley, the primary maintainer of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two very minor comments for cleanup. initially, I was hesitant to update the core version without parity but I don't see any harm in making this library better for the portion of the API it does support while not compromising what it doesn't (yet). well done!
please don't forget to accept the CLA, I can't merge this without it :)
@joegilley Cleanup done :) |
@joegilley up |
Fixed the issue #7. This pull request doesn't add the newest features from the core library it only update the ones already provided in the bindings