Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cleanup and pin cibuildwheel #188

Merged
merged 3 commits into from
Jun 8, 2021
Merged

ci: cleanup and pin cibuildwheel #188

merged 3 commits into from
Jun 8, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 18, 2021

Cleaning up the file just a bit, mostly pinning cibuildwheel, as version 2.0 will drop Python 2/3.5, which might be a surprise if you just always install the latest version. It looks like you might use dependabot + pinning in actions, so you might like the action form of cibuildwheel better, but it's about to move from joerick/cibuildwheel to pypa/cibuildwheel, so that could be done after the move to pick up the shiny new name. :) Edit: moved, so using action.

@CLAassistant
Copy link

CLAassistant commented May 18, 2021

CLA assistant check
All committers have signed the CLA.

@henryiii henryiii closed this May 18, 2021
@henryiii henryiii reopened this May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #188 (3e45e57) into master (c3593ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e45e57 differs from pull request most recent head d6dc29b. Consider uploading reports for the commit d6dc29b to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          213       213           
=========================================
  Hits           213       213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3593ec...d6dc29b. Read the comment docs.

@dfellis
Copy link
Collaborator

dfellis commented May 18, 2021

So this refactoring doesn't seem to work (yet).

@henryiii
Copy link
Contributor Author

I thought pipx recognized a version number without having to use --spec. The action doesn't have to worry about that.

@ajfriend
Copy link
Contributor

ajfriend commented Jun 8, 2021

Awesome! Thanks @henryiii! Would you happen to know if it's similarly easy to extend this to also build for aarch64 and Apple Silicon?

@ajfriend ajfriend merged commit 597e6ef into uber:master Jun 8, 2021
@ajfriend
Copy link
Contributor

ajfriend commented Jun 8, 2021

But I should also figure out how this overlaps with #183

@henryiii henryiii deleted the patch-1 branch June 8, 2021 03:01
@henryiii
Copy link
Contributor Author

henryiii commented Jun 8, 2021

It should be pretty easy, depends on if you support Aarch64 (#183) and if there are any dependencies that don't support Apple Silicon yet. I could draft an example PR, possibly.

@henryiii henryiii mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants