-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to api functions class #216
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4efd64b
Sketch of class-based api_functions
kylebarron c698be8
Remove dynamic globals update
kylebarron 2cd9e42
Add script to build api functions
kylebarron dab3b63
Update types
kylebarron 05c85a8
Merge branch 'master' of github.com:uber/h3-py into kyle/class-api-fu…
kylebarron e508cbc
Pass tests on 3.7
kylebarron 2745a98
Use type comments to support python 2
kylebarron 1af8f11
Turn off fail-fast
kylebarron b4c5514
Exclude 3.5 on windows
kylebarron a2afa2a
Fix 3.10
kylebarron daf7059
Merge branch 'master' into kyle/class-api-functions
kylebarron 5ac6613
Use introspection in api_functions script
kylebarron f20ddce
Merge branch 'master' into kyle/class-api-types
kylebarron c058463
Remove api_functions script
kylebarron 368ddf7
Revert api/__init__ changes
kylebarron 9401df5
Merge branch 'master' into kyle/class-api-types
kylebarron ea3d66f
Add types to unstable.vect
kylebarron 16ad670
Fix resolution return type
kylebarron 04aa7ef
Minimal type tests
kylebarron eca42c9
Ignore line length on type comment
kylebarron 58f5e4f
Don't run type tests on 3.5
kylebarron bdeec9f
Test static methods
kylebarron 0c1e420
WIP start basic_str type tests
kylebarron 22d2b3d
Add a few more tests
kylebarron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[mypy] | ||
ignore_missing_imports = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted before merging