Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more sdist files #259

Merged
merged 7 commits into from
Jun 6, 2022
Merged

Remove more sdist files #259

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d230846
remove scripts/examples/apps
ajfriend Jun 4, 2022
c9bb628
BUILD_FUZZERS OFF
ajfriend Jun 6, 2022
1ac35eb
ENABLE_FORMAT off
ajfriend Jun 6, 2022
1617639
turn off all the things (and sort options)
ajfriend Jun 6, 2022
4d8e59d
mac attack
ajfriend Jun 6, 2022
f9869aa
see if there's a build time difference
ajfriend Jun 6, 2022
302cae6
back to the future
ajfriend Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,22 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_BUILD_TYPE Release)

# Avoid building tooling we won't need for release
# See all options with `cmake -LA` in an `h3/build` directory
set(BUILD_ALLOC_TESTS OFF CACHE BOOL "" FORCE)
set(BUILD_BENCHMARKS OFF CACHE BOOL "" FORCE)
set(BUILD_FILTERS OFF CACHE BOOL "" FORCE)
set(BUILD_FUZZERS OFF CACHE BOOL "" FORCE)
set(BUILD_GENERATORS OFF CACHE BOOL "" FORCE)
set(BUILD_TESTING OFF CACHE BOOL "" FORCE)
set(ENABLE_COVERAGE OFF CACHE BOOL "" FORCE)
set(ENABLE_DOCS OFF CACHE BOOL "" FORCE)
set(ENABLE_FORMAT OFF CACHE BOOL "" FORCE)
set(ENABLE_LIBFUZZER OFF CACHE BOOL "" FORCE)
set(ENABLE_LINTING OFF CACHE BOOL "" FORCE)
# See all options with `cmake -LA` in an `h3/build` directory,
# or at https://h3geo.org/docs/next/core-library/compilation-options/
macro(turn_off option_name)
set(${option_name} OFF CACHE BOOL "" FORCE)
endmacro()
turn_off(BUILD_ALLOC_TESTS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUILD_ALLOC_TESTS should not have any effect when BUILD_TESTING is off. Harmless to disable it though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a suspicion that that was true, but yeah, figured it couldn't hurt to just disable everything to make sure.

turn_off(BUILD_BENCHMARKS)
turn_off(BUILD_FILTERS)
turn_off(BUILD_FUZZERS)
turn_off(BUILD_GENERATORS)
turn_off(BUILD_TESTING)
turn_off(ENABLE_COVERAGE)
turn_off(ENABLE_DOCS)
turn_off(ENABLE_FORMAT)
turn_off(ENABLE_LIBFUZZER)
turn_off(ENABLE_LINTING)
Comment on lines +10 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, can you compare compilation times before and after this change? Does this make it a lot faster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked some other compilation times. There's maybe a gain. I'll try some runs here for a clearer comparison.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be faster, based on the last two runs I looked at, but hard to tell how much is random variation.

Old config
Screen Shot 2022-06-06 at 3 51 11 PM

New config
Screen Shot 2022-06-06 at 3 51 40 PM


# Build the core library as static
set(BUILD_SHARED_LIBS OFF)
Expand Down