Fix undefined memory allocation functions on Mac OSX #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Jun 29, 2020
chenrui333
approved these changes
Jun 29, 2020
isaacbrodsky
force-pushed
the
mac-fix-undefined-memory-allocators
branch
from
95ea0e0 to
9aadf6b
Compare
mrdvt92
pushed a commit
to mrdvt92/h3
that referenced
this pull request
Jun 19, 2022
…tors Fix undefined memory allocation functions on Mac OSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361, thanks @chenrui333 for reporting.
Edit: In addition to my comment on that issue, I should add that this should have been caught in Travis CI's OSX build - we should probably see if we can get this reproduced in CI to prevent regression.