Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX_H3_RES should be tested inclusive #820

Merged
merged 1 commit into from
Mar 11, 2024
Merged

MAX_H3_RES should be tested inclusive #820

merged 1 commit into from
Mar 11, 2024

Conversation

isaacbrodsky
Copy link
Collaborator

I think this is an oversight in these tests, MAX_H3_RES is the last valid resolution, so we should include it.

@coveralls
Copy link

Coverage Status

coverage: 98.827%. remained the same
when pulling 7d841a6 on isaacbrodsky:max-h3-res-inclusive
into 094699b on uber:master.

nrabinowitz
nrabinowitz approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, TY

@isaacbrodsky isaacbrodsky merged commit d00624c into uber:master Mar 11, 2024
34 checks passed
@isaacbrodsky isaacbrodsky deleted the max-h3-res-inclusive branch July 15, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfellis dfellis dfellis approved these changes

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacbrodsky @coveralls @nrabinowitz @dfellis