Testing bzlmod earlier #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
approved these changes
Sep 25, 2023
Antonito
pushed a commit
to tentenapp/hermetic_cc_toolchain
that referenced
this pull request
Sep 25, 2023
bzlmod requires a different flag to override external dependencies. We need to parameterize that flag depending on whether an example has bzlmod enabled. With this change, our CI covers the the case of a test module depending on hermetic_cc_toolchain as a `bazel_dep`, pointing to a release archive created from HEAD and running all tests in the test module. Hopefully we can catch issues in our CI, rather than on BCR's CI after a release is cut. With this change, we no longer run the tests again in BCR's CI and no longer need to include the example in the release archive. We only need to verify that the latest release can be loaded by the [anonymous test module](https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#anonymous-module-test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bzlmod requires a different flag to override external dependencies. We need to parameterize that flag depending on whether an example has bzlmod enabled. With this change, our CI covers the the case of a test module depending on hermetic_cc_toolchain as a
bazel_dep, pointing to a release archive created from HEAD and running all tests in the test module. Hopefully we can catch issues in our CI, rather than on BCR's CI after a release is cut.With this change, we no longer run the tests again in BCR's CI and no longer need to include the example in the release archive. We only need to verify that the latest release can be loaded by the anonymous test module.