Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in Carthage compatible way #346

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Run tests in Carthage compatible way #346

merged 1 commit into from
Jun 18, 2020

Conversation

brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Jun 18, 2020 •
edited
Loading

Now that the shared test-specific schemes are gone we need the NeedleFoundation scheme to run its tests.

Fixes the CI failure created by #309.

rudro
rudro approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rudro rudro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and the quick turnaround. We use buck/bazel at work, so debugging Carthage issues requires me to relearn some of the Carthage setup we did here.

@rudro rudro merged commit 1454bc4 into uber:master Jun 18, 2020
@brentleyjones
Copy link
Contributor Author

We are also now on Bazel, so this is now for others 😄.

@brentleyjones brentleyjones deleted the fix-CI-scheme branch June 18, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudro rudro rudro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentleyjones @rudro