Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore internal properties in components #459

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Ignore internal properties in components #459

merged 2 commits into from
Aug 16, 2023

Conversation

rudro
Copy link
Contributor

@rudro rudro commented May 19, 2023

- Fixes #458 (see bug for details)
@rudro rudro requested a review from ryanaveo May 19, 2023 17:12
Copy link
Collaborator

@ryanaveo ryanaveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudro rudro merged commit 008c094 into master Aug 16, 2023
@angelstoone
Copy link

angelstoone commented Sep 4, 2023

Hey folks 👋🏻 I just wanted to mention that it would be nice to update the v0.24.0 release changelog by mentioning this as a breaking change wdyt? At least for us, it was because we were having mostly internals in our BootstrapComponent 😅

@xezero xezero mentioned this pull request Mar 6, 2024
xezero added a commit to airchat-org/needle that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal properties of Components should be ignored
3 participants