-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C API] NP_GetDims implementation #422
Conversation
I know linter shown problem and I ran autofix and didn't check it after athat! It means autofix doesn't update C file! Will look on it and update. |
The lint script currently fails on the first linter that fails (for example if you have an error in a BUILD file, it won't even look at Python and C++). I think autofix has this behavior as well. On my todo list to fix this :) For now, I usually just run |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 89.53% 89.54% +0.01%
==========================================
Files 90 90
Lines 5199 5205 +6
==========================================
+ Hits 4655 4661 +6
Misses 544 544
Continue to review full report at Codecov.
|
9efcb6a
to
2895753
Compare
2895753
to
89141c8
Compare
### Summary: Continue with basic implementation of a C API for Neuropod. Issue uber#407 ### Test Plan: Added test that test returned values of number of dims and data in dims array.
Summary:
Continue with basic implementation of a C API for Neuropod. Issue #407
Test Plan:
Added test that test returned values of number of dims and data in dims array.