Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C API] NP_GetDims implementation #422

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Conversation

vkuzmin-uber
Copy link
Contributor

Summary:

Continue with basic implementation of a C API for Neuropod. Issue #407

Test Plan:

Added test that test returned values of number of dims and data in dims array.

@vkuzmin-uber
Copy link
Contributor Author

I know linter shown problem and I ran autofix and didn't check it after athat! It means autofix doesn't update C file! Will look on it and update.

@VivekPanyam
Copy link
Collaborator

I know linter shown problem and I ran autofix and didn't check it after athat! It means autofix doesn't update C file! Will look on it and update.

The lint script currently fails on the first linter that fails (for example if you have an error in a BUILD file, it won't even look at Python and C++). I think autofix has this behavior as well. On my todo list to fix this :)

For now, I usually just run tools/lint.sh again just to make sure everything is fine.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #422 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   89.53%   89.54%   +0.01%     
==========================================
  Files          90       90              
  Lines        5199     5205       +6     
==========================================
+ Hits         4655     4661       +6     
  Misses        544      544              
Impacted Files Coverage Δ
source/neuropod/bindings/c/np_tensor.cc 87.50% <100.00%> (+7.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a10bdd...89141c8. Read the comment docs.

@VivekPanyam VivekPanyam merged commit 9992207 into uber:master Aug 28, 2020
vkuzmin-uber added a commit to vkuzmin-uber/neuropod that referenced this pull request Aug 31, 2020
### Summary:
Continue with basic implementation of a C API for Neuropod. Issue uber#407

### Test Plan:
Added test that test returned values of number of dims and data in dims array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants