Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Torch 1.10.2 #531

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add support for Torch 1.10.2 #531

merged 1 commit into from
Feb 18, 2022

Conversation

VivekPanyam
Copy link
Collaborator

Summary:

This PR adds support for Torch 1.10.2 and adds a build to the CI matrix to test it

Test Plan:

CI

@tgaddair
Copy link

Thanks for putting this PR together, @VivekPanyam. Is this good to go, or are there issues that need to be addressed? (never sure with CI what's flaky and what's not)

@VivekPanyam
Copy link
Collaborator Author

Thanks for putting this PR together, @VivekPanyam. Is this good to go, or are there issues that need to be addressed? (never sure with CI what's flaky and what's not)

Need to land #532 first (pip broke on py3.6 because of EOL + a python ppa changed and broke CI). We're running CI on GPU spot instances and they've been getting terminated a lot over the last few days so it's taking a bit longer than expected for builds to pass.

Hopefully we'll be able to get this out by the end of the week

@tgaddair
Copy link

Awesome, that sounds great. Thanks for the update.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #531 (1df5469) into master (925ca9f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files         104      104           
  Lines        6940     6940           
=======================================
  Hits         6009     6009           
  Misses        931      931           
Impacted Files Coverage Δ
...urce/neuropod/backends/torchscript/torch_tensor.hh 72.72% <ø> (ø)
source/neuropod/internal/backend_registration.cc 86.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925ca9f...1df5469. Read the comment docs.

@VivekPanyam VivekPanyam merged commit c4ed8c3 into master Feb 18, 2022
@VivekPanyam VivekPanyam deleted the torch_110 branch February 18, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants