Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Run CI against pyspark 3.4 #791

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

WeichenXu123
Copy link
Collaborator

Run CI against pyspark 3.4

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b0775a) 86.24% compared to head (a8befd5) 86.24%.

❗ Current head a8befd5 differs from pull request most recent head 2e68138. Consider uploading reports for the commit 2e68138 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          84       84           
  Lines        5090     5090           
  Branches      790      790           
=======================================
  Hits         4390     4390           
  Misses        560      560           
  Partials      140      140           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
Copy link
Collaborator Author

WeichenXu123 commented Feb 28, 2023

Failure tests are all about legacy dataset (dataset saved by old version petastorm) which we don't need to support it.

petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.4.3] FAILED [ 61%]
petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.7.6] PASSED [ 61%]
petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.5.1] FAILED [ 61%]
petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.4.0] FAILED [ 61%]
petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.7.0] FAILED [ 62%]
petastorm/tests/test_reading_legacy_datasets.py::test_reading_legacy_dataset[file:///petastorm/petastorm/tests/data/legacy/0.6.0] FAILED [ 62%]

@selitvin
Copy link
Collaborator

selitvin commented Apr 4, 2023

Failure tests are all about legacy dataset (dataset saved by old version petastorm) which we don't need to support it.

@WeichenXu123 : can you please delete these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants