Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TypeScript to Piranha Playground #577

Closed
wants to merge 4 commits into from
Closed

Conversation

kevtran2
Copy link

This PR adds TypeScript support to the playground.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kevtran2
❌ Kevin Tran


Kevin Tran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ketkarameya
Copy link
Collaborator

Hey @kevtran2 thank you for your contribution.
I do not have a deep understanding for this part of the code, but does adding the typescript option work ? did u try to use the playground ?

@danieltrt
Copy link
Collaborator

This is working, I walked Kevin through this change

@kevtran2
Copy link
Author

kevtran2 commented Sep 1, 2023

I am having issues merging since CLAassistant wants me to complete two CLAs, one under my github account kevtran2(which I did) and for "Kevin Tran" as a contributor. I don't know why it is confusing my identity as two accounts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants