Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use newer node version #49

Merged
merged 1 commit into from
Aug 25, 2017
Merged

use newer node version #49

merged 1 commit into from
Aug 25, 2017

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Aug 3, 2017

v4.0 had problems with computed props which got fixed in v4.1 (nodejs/node#2507 or v4.0 release notes in the Known Issues section).

This issue is currently encountered when running npm run build. The entry property of the webpack config will evaluate to {} and therefore nothing will be built.

4.0 had problems with computed props which got fixed in 4.1
see nodejs/node#2507
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.932% when pulling d74eaec on eps1lon:fix-node-computed-props into 18ee88e on uber:master.

@saminzadeh saminzadeh merged commit ce8ab0f into uber:master Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants