Fix(ReactVis): Stop Setting Refs On Stateless Components (#867)

* Fix(ReactVis): Ref On Stateless Component Error * cleanup * fix lint * add regression test * fix lint * remove regression test
uber · Jul 11, 2018 · 1ab5cc7 · 1ab5cc7
1 parent 3bb38c9
commit 1ab5cc7
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/plot/xy-plot.js b/src/plot/xy-plot.js
@@ -476,11 +476,11 @@ class XYPlot extends React.Component {
       return React.cloneElement(child, {
         ...dimensions,
         animation,
-        ref: (ref) => {
-          if (dataProps) {
-            this[`series${seriesProps[index].seriesIndex}`] = ref;
-          }
-        },
+        ...(dataProps ?
+        {
+          ref: ref => (this[`series${seriesProps[index].seriesIndex}`] = ref)
+        } :
+        {}),
         ...seriesProps[index],
         ...scaleMixins,
         ...child.props,