Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-plugin-jest and rename all test files as *.test.js #1339

Merged
merged 6 commits into from
May 29, 2020
Merged

Add eslint-plugin-jest and rename all test files as *.test.js #1339

merged 6 commits into from
May 29, 2020

Conversation

reitlepax
Copy link
Contributor

@reitlepax reitlepax commented May 28, 2020 •
edited
Loading

Fixes #1337
See #1323

Reviewing commit by commit should make it easier to read since I renamed many files in the last commit

@Xiot
Copy link
Contributor

Xiot commented May 29, 2020 

error semver@7.3.2: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"

I say we just get rid of Node 8 in our CI

@reitlepax
Copy link
Contributor Author 

error semver@7.3.2: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"

I say we just get rid of Node 8 in our CI

agreed :)

@reitlepax reitlepax force-pushed the add-eslint-plugin-jest branch from 0042e24 to 747aa86 Compare May 29, 2020 08:12
@Xiot Xiot merged commit 2b6d5d3 into uber:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiot Xiot Xiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add eslint-plugin-jest to eslint config
2 participants
@reitlepax @Xiot