Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 17 #1473

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Upgrade to React 17 #1473

merged 1 commit into from
Sep 9, 2024

Conversation

Sergio-Mira
Copy link
Contributor

@Sergio-Mira Sergio-Mira commented Feb 4, 2023

Attempt to upgrade to React 17 #1356

Signed-off-by: Sergio-Mira <sergio.mira@zendesk.com>
@CLAassistant
Copy link

CLAassistant commented Feb 4, 2023

CLA assistant check
All committers have signed the CLA.

@jkytomak
Copy link

jkytomak commented Sep 9, 2024

This looks reallly straigthforward PR.
@kenns29 any chance merging this?
@Sergio-Mira , did I understand right that this makes react-vis even work with React 18? Referring to this comment of yours:
jaegertracing/jaeger-ui#1173 (comment)

@jkytomak jkytomak mentioned this pull request Sep 9, 2024
@Sergio-Mira
Copy link
Contributor Author

I believe that the current version works with React 18 already, as those warnings are still warnings in those React 18.X versions. You can see that jaeger-ui is using React 18 here and using the current version of react-vis: https://github.com/jaegertracing/jaeger-ui/blob/main/yarn.lock#L9025

@jkytomak
Copy link

jkytomak commented Sep 9, 2024

I believe that the current version works with React 18 already, as those warnings are still warnings in those React 18.X versions. You can see that jaeger-ui is using React 18 here and using the current version of react-vis: https://github.com/jaegertracing/jaeger-ui/blob/main/yarn.lock#L9025

Great, thanks! We got earlier plenty of type errors when trying to upgrade. Looks like manually resolving right types for 17 solved it also for 18. Had the problem first when trying to upgrade newest 17 types.

@kenns29 kenns29 self-requested a review September 9, 2024 20:22
@kenns29 kenns29 merged commit fe9794c into uber:master Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants