Remove unused app_name string resource #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davissuber
force-pushed
the
ds-remove-string
branch
14 times, most recently
from
493e513
to
f317e6d
Compare
davissuber
force-pushed
the
ds-remove-string
branch
from
f317e6d
to
ee0fce2
Compare
davissuber
commented
Sep 20, 2024
| @@ -53,7 +53,7 @@ jobs: | |||
| abi: x86 | |||
| - name: Full check | |||
| run: ./gradlew check --stacktrace | |||
| - uses: actions/upload-artifact@v2 | |||
| - uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
v2 is deprecated and without bumping it - this job automatically fails.
davissuber
commented
Sep 21, 2024
| @@ -14,7 +14,7 @@ on: | |||
| jobs: | |||
| build: | |||
| name: JDK ${{ matrix.java_version }} | |||
| runs-on: macOS-latest | |||
| runs-on: macos-13 | |||
There was a problem hiding this comment.
It's a bit tricky to balance between the 3 versions:
- emulator api level (currently at
21, bumping to newer ones means we need to move the abi away fromx86) - emulator abi (due to this being on macos, the only real long term option is
arm64-v8a) - osx version (VMs on Apple silicon is allegedly having some problem with emulators, which may get resolved in osx15 with M3 chips; I am guessing it will be some time before we have M3 running osx15 on github actions
I am not sure if it make sense to consider moving to ubuntu (like our other github actions) and fight the emulator war there.
psteiger
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemingly trivial removal of an unused
app_namecan help make resource resolution a bit easier downstream sinceapp_nameis often the resource name that APKs are using to identify the name of the application - it seems unlikely anyone is using simple-store for this string.