Restore the original Registrar interface #480
Merged
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,11 @@ import ( | |||
| "golang.org/x/net/context" | |||
| ) | |||
|
|
|||
| // TracerProvider returns an OpenTracing Tracer | |||
| type TracerProvider interface { | |||
There was a problem hiding this comment.
Is there any advantages to having this be public? While the other option would duplicate the interface, I wonder if it's better to keep the tchannel API smaller
There was a problem hiding this comment.
well, the only reason is that it's used from json and thrift packages. But we could have a public helper method in tracing.go to extract the tracer from the registrar, wdyt?
There was a problem hiding this comment.
Separate public method seems a little better, let's do that.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending Registrar interface in #426 caused compile errors in ringpop-go. This change restores the original Registrar interface and pulls the tracer from it by casting to TracerProvider