Remove UberButton_DEPRECATED #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the last remaining references to UberButton_DEPRECATED and updates RideRequestButton to match the previous UI. The sample app UberSDK has also been updated to allow manually testing the new button.
Changes
Remove UberButton_DEPRECATED
This UI was deprecated in an earlier PR and was only referenced in RideRequestButton. After migrating RideRequestButton to subclass the new UberButton, UberButton_DEPRECATED could safely be removed.
Sample App
Minor changes were made to the sample all to add the new RideRequestButton and make some more space for UI (AuthResponseView).
Testing
Unit Tests
Existing unit tests for the deprecated UberButton were updated to support the new button
Manual Testing