Logout API #315
Merged
Logout API #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new top-level API to UberAuth to "logout" the current user. This function deletes the stored auth token by:
The equivalent API has been added to AuthorizationCodeAuthProvider to delete the token as described in (2).
After token deletion, UberAuth will release the stored currentContext.
Another computed property
isLoggedInwas added for convenience to determine if a token exists in the keychain.Changes
UberAuth API
Added new static and instance methods to UberAuth for logout as described above. Added computed isLoggedIn property to determine auth state.
AuthorizationCodeAuthProvider API
Added methods to AuthorizationCodeAuthProvider to delete the token for logout. Added computed isLoggedIn property to determine auth state.
Testing
Unit Tests
Added unit tests to ensure tokens are deleted and currentContext released properly
Manual Testing
Updated the UberSDK sample app to use the new APIs for manual testing.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-10.at.11.18.10.mp4