Bump tchannel and unpin broken thrift #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanfsdf
commented
Feb 6, 2019
abhishekparwal
previously requested changes
Feb 6, 2019
Ryanfsdf
commented
Feb 6, 2019
jacobgreenleaf
approved these changes
Feb 7, 2019
ChuntaoLu
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tchannel-go from 1.5.0 to ^1.6.0. Hard pinning 1.5.0 was problematic because other projects (edge-gateway) require tchannel>=1.10.0 due to other dependencies.
The most logical fix would be bumping 1.5.0 to ^1.5.0 but 1.6.0 introduced a change to the number of logs outputted to
zap.logger.infowhich breaks some tests in Zanzibar. Thus I changed 1.5.0 to ^1.6.0 and fixed the tests which were expecting a certain number ofzap.logger.infooutput.Also, I removed the pin for apache/thrift because version 0.12.0 introduces a breaking change and the pin ^0.10.0 imports 0.12.0, overriding tchannel's pin of '0.9.3>=, < 0.11.0' and introducing a breaking change.