Provide solution to filter log fields by user demand #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 22, 2019 14:43
edwinzg
reviewed
Mar 4, 2019
| @@ -65,5 +66,7 @@ | |||
| "tchannel.port": 7784, | |||
| "tchannel.processName": "example-gateway", | |||
| "tchannel.serviceName": "example-gateway", | |||
| "useDatacenter": false | |||
| "tchannel.clients.requestUUIDHeaderKey": "x-request-uuid", | |||
There was a problem hiding this comment.
I wonder if we can just use the same requestUUIDHeader for tchannel and http
edwinzg
reviewed
Mar 4, 2019
| @@ -114,18 +115,17 @@ func GetEndpointRequestHeadersFromCtx(ctx context.Context) map[string]string { | |||
| } | |||
|
|
|||
| // withRequestUUID returns a context with request uuid. | |||
| func withRequestUUID(ctx context.Context, reqUUID uuid.UUID) context.Context { | |||
| func withRequestUUID(ctx context.Context, reqUUID string) context.Context { | |||
There was a problem hiding this comment.
why make this a string instead of a UUID?
There was a problem hiding this comment.
This is used for log field, which will be zap.String, keeping it uuid.UUID means useless conversion between UUID and string.
edwinzg
approved these changes
Mar 4, 2019
jacobgreenleaf
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things: