Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary solution to support running tests with bazel #587

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

ChuntaoLu
Copy link
Contributor

This PR hard codes a temporary solution to support running tests with bazel where accessing to test config files is restricted.
It is obvious that this approach isn't ideal since it tailors to bazel's specific needs, therefore temporary.

Copy link

@linzhp linzhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe worth putting this url in the comment in case people wondering where TEST_SRCDIR and TEST_WORKSPACE come from.

@coveralls
Copy link

coveralls commented Apr 15, 2019

Coverage Status

Coverage increased (+0.009%) to 67.581% when pulling 6fd6e4f on lu.bazel into bf225b3 on master.

@ChuntaoLu
Copy link
Contributor Author

LGTM. Maybe worth putting this url in the comment in case people wondering where TEST_SRCDIR and TEST_WORKSPACE come from.

Good tip, updated the PR with link in code comments.

@ChuntaoLu ChuntaoLu merged commit 06ec349 into master Apr 15, 2019
@ChuntaoLu ChuntaoLu deleted the lu.bazel branch April 15, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants