Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use clientConfig struct for unmarshalling yarpc clients instead of generic classConfig #618

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

rpatali
Copy link
Contributor

@rpatali rpatali commented Aug 7, 2019

  • There are additional configurations such as exposed methods, sidecar router, etc. that need to be configured in the Gateway and the generic ClassConfig doesn't provide a strict contract for those to be present.
  • Using ClientConfig makes the implementation for the various Clients consistent in implementation.
  • ClientConfig always assumes thriftFile whereas YARPC clients use protoFiles, migrating clientConfig to a IDL agnostic idlFile naming

This is a breaking change for existing users of Zanzibar due to the name change and probably requires a version bump.

The scope of this diff is to only handle the client-side changes to unify Thrift vs. Proto struct to unblock other development that depends on this struct. Will be following up with a thorough cleanup of thriftFile -> idlFile for the endpoint as well as all other references and implement non-nil SpecGenerator impl for YARPC Client.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 67.849% when pulling 231e6b2 on rpatali/yarpcClientConfig into e6898db on master.

@rpatali rpatali merged commit 2ab0eaa into master Aug 9, 2019
@rpatali rpatali deleted the rpatali/yarpcClientConfig branch August 9, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants