Argo/query params for all methods #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing in the standards definitions preclude query params for methods other than GET We have use-cases where an endpoint wanted to use DELETE with query params and that was used by the downstream service. With this change, a few things: - Allowed other methods to process query params - Fixed the test-cases -- all query params need to have the http.ref = "query.xxx" annotation In the test cases, we were grandfathering non-annotated fields in the struct as query params since these were only for GET and it worked well - One test case added for delete with query params
rpatali
reviewed
Aug 21, 2019
rpatali
approved these changes
Aug 21, 2019
argouber
added a commit
that referenced
this pull request
Aug 21, 2019
Allow query params on ALL http methods Nothing in the standards definitions preclude query params for methods other than GET We have use-cases where an endpoint wanted to use DELETE with query params and that was used by the downstream service. With this change, a few things: - Allowed other methods to process query params - Fixed the test-cases -- all query params need to have the http.ref = "query.xxx" annotation In the test cases, we were grandfathering non-annotated fields in the struct as query params since these were only for GET and it worked well - One test case added for delete with query params
smb158
pushed a commit
that referenced
this pull request
Aug 28, 2019
Allow query params on ALL http methods Nothing in the standards definitions preclude query params for methods other than GET We have use-cases where an endpoint wanted to use DELETE with query params and that was used by the downstream service. With this change, a few things: - Allowed other methods to process query params - Fixed the test-cases -- all query params need to have the http.ref = "query.xxx" annotation In the test cases, we were grandfathering non-annotated fields in the struct as query params since these were only for GET and it worked well - One test case added for delete with query params
argouber
added a commit
that referenced
this pull request
Sep 3, 2019
This reverts commit 6455da6. While we fix it to not break existing clients
argouber
added a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow query params for all HTTP methods