Support variadic parameters in augmented mock client #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2020 08:57
This PR adds support for variadic parameters in the augmented mock client `MockClientWithFixture`. This feature applies to any type of clients that has methods of variadic parameters, but particularly applies to generated gRPC clients, where each client method accepts the variadic parameter of type `yarpc.CallOption`. One caveat is that Go does not support function comparsion (even `reflect.DeepEqual` won't work), see details in golang/mock#324. So in the case of gRPC mock clients, it is not possible to match the `yarpc.CallOption` variadic parameters, because it internally has a function field. The workout is to always set `Arg{n}Any` in the fixture pacakge to the number of variadic parameters so that macther checks pass for them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for variadic parameters in the augmented mock client
MockClientWithFixture. This feature applies to any type of clients thathas methods of variadic parameters, but particularly applies to generated
gRPC clients, where each client method accepts the variadic parameter of
type
yarpc.CallOption.One caveat is that Go does not support function comparsion (even
reflect.DeepEqualwon't work), see details ingolang/mock#324. So in the case of gRPC mock
clients, it is not possible to match the
yarpc.CallOptionvariadicparameters, because it internally has a function field. The workout is to
always set
Arg{n}Anyin the fixture pacakge to the number of variadicparameters so that macther checks pass for them.