Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use context logger #748

Merged
merged 21 commits into from
Feb 10, 2021
Merged

Update use context logger #748

merged 21 commits into from
Feb 10, 2021

Conversation

shashipuchak
Copy link
Contributor

No description provided.

@shashipuchak
- use context logger
d21ef9c 
- make ServerHTTPResponse error object accesible
@shashipuchak
update example files
c982700
@rpatali
Copy link
Contributor

rpatali commented Oct 28, 2020

Note this is a breaking change. make sure to note that in the changes.md

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

rpatali
rpatali approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@rpatali rpatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 69.216% when pulling 11750d3 on update_use_context_logger into fea477f on master.

@amit-lamba amit-lamba merged commit d70d8c8 into master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpatali rpatali rpatali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shashipuchak @rpatali @CLAassistant @coveralls @amit-lamba