Expose DepsTree through the main fx module #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Updates the main.tmpl file to expose the server's dependency tree so that each of the underlying components can be pluggable into other applications. For change #1, this change should not be merged back into the main branch because it leaks internal abstractions from the main server. The change is needed for internal reasons.
bennytran-uber
requested review from
abhishekparwal and
srivastavankit
and removed request for
abhishekparwal
srivastavankit
approved these changes
Jun 6, 2022
chirayu
added a commit
that referenced
this pull request
Jul 10, 2023
* Add configurability for tchannel server IP when set in the configuration file * Expose DepsTree through the main fx module (#821)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the main.tmpl file to expose the server's dependency tree so
that each of the underlying components can be pluggable into other applications.
This change should not be merged back into the main
branch because it leaks internal abstractions from the main
server. The change is needed for internal reasons.