Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(hysteresisdriver.py): replace test class with a function #45

Merged
merged 2 commits into from
Oct 26, 2023
Merged

chore(hysteresisdriver.py): replace test class with a function #45

merged 2 commits into from
Oct 26, 2023

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Oct 25, 2023

I haven't changed any of the logic how and what we test.

@lang-m lang-m requested a review from swapneelap October 25, 2023 09:20
swapneelap
swapneelap approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@swapneelap swapneelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏽

@lang-m lang-m merged commit 8607db6 into master Oct 26, 2023
6 checks passed
@lang-m lang-m deleted the simplify-hystesis-test branch October 26, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapneelap swapneelap swapneelap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lang-m @swapneelap