Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imple Batch spacing props #107

Merged
merged 14 commits into from
Jun 18, 2024
Merged

Imple Batch spacing props #107

merged 14 commits into from
Jun 18, 2024

Conversation

8845musign
Copy link
Collaborator

Changes

  • To be able to specify padding and margin at once
  • Test was done mainly by unit test.

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner June 14, 2024 12:11
@8845musign 8845musign self-assigned this Jun 14, 2024
@8845musign
Copy link
Collaborator Author

may be conflict #105

@takanorip
Copy link
Contributor

@8845musign resolve conflicts please 🙏

@8845musign
Merge branch 'main' into batch-spacing-props
ffa92a9 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@takanorip takanorip merged commit 2b9c2cc into ubie-oss:main Jun 18, 2024
2 checks passed
@8845musign 8845musign deleted the batch-spacing-props branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip