Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add gapVariables & fix Stack #109

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: add gapVariables & fix Stack #109

merged 1 commit into from
Jun 20, 2024

Conversation

takanorip
Copy link
Contributor

@takanorip takanorip commented Jun 20, 2024 •
edited
Loading

Changes

  • Modified Stack to work even when spacing is not specified.
  • Created a gapVariables function to unify processing with Flex.

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@takanorip takanorip self-assigned this Jun 20, 2024
@takanorip takanorip requested a review from 8845musign as a code owner June 20, 2024 11:15
@8845musign
Copy link
Collaborator

LGTM!

@8845musign 8845musign merged commit 1a86877 into main Jun 20, 2024
2 checks passed
@takanorip takanorip deleted the add-spacing-none branch June 21, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8845musign 8845musign 8845musign approved these changes

Assignees

@takanorip takanorip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takanorip @8845musign