Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CheckboxGroup to ChekboxCard + α #113

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Support CheckboxGroup to ChekboxCard + α #113

merged 6 commits into from
Jun 27, 2024
+128 −39

Conversation

8845musign
Copy link
Collaborator

@8845musign 8845musign commented Jun 27, 2024 •
edited
Loading

Changes

  • Support CheckboxGroup to ChekboxCard
  • Reduced Checkbox animations
    • To flicker
  • CheckboxGroup and RadioGropu to make labels optional
    • In some cases, there is a separate heading instead of a label because

Reduced Checkbox animations:
https://github.com/ubie-oss/ubie-ui/assets/10903851/9b8a1538-ea35-4248-acad-8d735ae042d9

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign marked this pull request as ready for review June 27, 2024 07:26
@8845musign 8845musign requested a review from takanorip as a code owner June 27, 2024 07:26
8845musign
8845musign commented Jun 27, 2024
View reviewed changes
src/components/RadioGroup/RadioGroup.tsx
export type Props = {
children: RadioComponent[];
children: ReactElement<typeof RadioButton>[] | ReactElement<typeof RadioCard>[];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not mix

@8845musign
Copy link
Collaborator Author

Implement wrapping for direction="row". convert to draft.

@8845musign 8845musign marked this pull request as draft June 27, 2024 09:11
@8845musign 8845musign self-assigned this Jun 27, 2024
@8845musign 8845musign marked this pull request as ready for review June 27, 2024 09:27
@takanorip takanorip merged commit 05a731a into ubie-oss:main Jun 27, 2024
2 checks passed
@8845musign 8845musign deleted the checkboxcard-and-checkboxgroup branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip