Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve children prop #116

Merged
merged 2 commits into from
Jun 29, 2024
Merged

improve children prop #116

merged 2 commits into from
Jun 29, 2024
+48 −22

Conversation

8845musign
Copy link
Collaborator

Changes

  • improve children prop
  • Support for some components
    • There wasn't enough time...
  • Most components require children
  • Also, add to comments elements that should not be specified as children

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner June 28, 2024 05:31
@8845musign 8845musign self-assigned this Jun 28, 2024
takanorip
takanorip approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@takanorip takanorip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good
fix lint please

@takanorip takanorip merged commit 52b8184 into ubie-oss:main Jun 29, 2024
2 checks passed
@8845musign 8845musign deleted the improve-children-prop branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip