Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling loading does not change the size of the buttons #118

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Enabling loading does not change the size of the buttons #118

merged 2 commits into from
Jul 5, 2024

Conversation

8845musign
Copy link
Contributor

Changes

  • Enabling loading does not change the size of the buttons
  • SPINNER icon is obsolete.
  • '通信中' label to be displayed.
  • The original button labels are transparent and placed as they are.

Screenshot

http://localhost:6006/?path=/story/button-button--loading

スクリーンショット 2024-07-04 17 52 38

  • size pattern
  • disabled & icon pattern

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner July 4, 2024 08:53
@8845musign 8845musign self-assigned this Jul 4, 2024
takanorip
takanorip approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@takanorip takanorip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@takanorip takanorip merged commit dc7c5bb into ubie-oss:main Jul 5, 2024
2 checks passed
@8845musign 8845musign deleted the improve-loading-prop-on-button branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip