Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Width Props to Layout Components #123

Merged
merged 9 commits into from
Jul 18, 2024
Merged

Add Width Props to Layout Components #123

merged 9 commits into from
Jul 18, 2024
+384 −32

Conversation

8845musign
Copy link
Collaborator

Changes

  • Add width, maxWidth, minWidth prop to Layout Components
  • Keep the full keywords that were originally there.

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner July 12, 2024 05:33
@8845musign 8845musign self-assigned this Jul 12, 2024
@takanorip
Copy link
Contributor

@8845musign I'm sorry, I missed some corrections during the conflict resolution. Please fix the lint errors. 🙏

@8845musign
Copy link
Collaborator Author

@takanorip fixed💪

@takanorip takanorip merged commit 70a1465 into ubie-oss:main Jul 18, 2024
2 checks passed
@8845musign 8845musign deleted the add-wdith-props branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip