Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ButtonCard color style #125

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix ButtonCard color style #125

merged 1 commit into from
Jul 25, 2024

Conversation

takanorip
Copy link
Contributor

Changes

  • add color-text-main to ButtonCard
    • Fixed an issue where the text color was set to the default link color in Safari.

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@takanorip takanorip requested a review from 8845musign as a code owner July 25, 2024 08:39
@takanorip takanorip requested a review from tonkotsuboy July 25, 2024 08:39
@takanorip takanorip self-assigned this Jul 25, 2024
tonkotsuboy
tonkotsuboy approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@tonkotsuboy tonkotsuboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最高！

@takanorip takanorip merged commit 36c41a9 into main Jul 25, 2024
2 checks passed
@takanorip takanorip deleted the fix-button-card-style branch July 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonkotsuboy tonkotsuboy tonkotsuboy approved these changes

@8845musign 8845musign Awaiting requested review from 8845musign 8845musign is a code owner

Assignees

@takanorip takanorip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takanorip @tonkotsuboy