Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gap alias prop to Stack Component #138

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

8845musign
Copy link
Collaborator

@8845musign 8845musign commented Oct 31, 2024

Changes

  • add gap prop
  • an alias for spacing prop
  • only one of the two props can be specified
スクリーンショット 2024-10-31 13 32 51

Error messages are confusing...

Check

  • [-] Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • [-] CSS not affected by inheritance
  • [-] Layout does not break even if there is an overflow
  • [-] Layout does not break when wraps
  • [-] Added new Component
    • Added data-* prop and id prop
  • [-] Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner October 31, 2024 04:33
@@ -48,7 +48,7 @@ type BaseProps = {
border?: 'gray' | 'grayThick' | 'primary' | 'primaryThick';
/**
* 幅を指定。fullは後方互換のため残している
* @defaultValue 'autp'
* @default 'auto'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up correction.
@defaultValue is a tsdoc specification. However, this description is not extracted correctly by vitals.

@8845musign 8845musign self-assigned this Oct 31, 2024
@takanorip takanorip merged commit c6ea851 into ubie-oss:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants