Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Icon component size specification with other components #140

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

8845musign
Copy link
Contributor

Retain the existing specification as an alias.

Changes

  • added expressions such as xxxl to size specification
  • added comment to specify methods such as 2xl not to be used in the future.

Screenshot

スクリーンショット 2024-11-01 15 20 19

alias specification:

スクリーンショット 2024-11-01 15 20 26

Check

No change in rendering results

  • [-] Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • [-] CSS not affected by inheritance
  • [-] Layout does not break even if there is an overflow
  • [-] Layout does not break when wraps
  • [-] Added new Component
    • Added data-* prop and id prop
  • [-] Updated Ubie Vitals or Added an update issue(if needed)

Retain the existing specification as an alias.

Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign 8845musign requested a review from takanorip as a code owner November 1, 2024 07:01
@8845musign 8845musign self-assigned this Nov 1, 2024
@takanorip takanorip merged commit 9db17a6 into ubie-oss:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants