Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefixIcon prop to Button components(icon alias) #141

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Add prefixIcon prop to Button components(icon alias) #141

merged 3 commits into from
Nov 7, 2024

Conversation

8845musign
Copy link
Collaborator

@8845musign 8845musign commented Nov 1, 2024 •
edited
Loading

Changes

blocked by #139

  • add prefixIcon prop to Button components
    • It is clearer to use “prefix” rather than simply “icon”.
    • unify naming with suffixIcon
  • prefixIcon is icon alias
    • I want to delete the icon prop, but it will take a lot of time, so I'll add an alias for now.

Screenshots

Button:
スクリーンショット 2024-11-01 21 55 48

LinkButton:
スクリーンショット 2024-11-01 21 56 20

Check

No change to the rendering result

  • [-] Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • [-] CSS not affected by inheritance
  • [-] Layout does not break even if there is an overflow
  • [-] Layout does not break when wraps
  • [-] Added new Component
    • Added data-* prop and id prop
  • [-] Updated Ubie Vitals or Added an update issue(if needed)

@8845musign
feat: allow icon prop to be specified by name
0438d23 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
feat: change text
68ff171 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
feat: add prefixIcon prop(icon alias)
5764ae4
@8845musign 8845musign marked this pull request as ready for review November 1, 2024 13:03
@8845musign 8845musign requested a review from takanorip as a code owner November 1, 2024 13:03
@takanorip takanorip merged commit bd3ce39 into ubie-oss:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip