Imple RadioGroup And CheckboxGroup #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>
Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>
Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>
Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>
8845musign
commented
Mar 11, 2024
| @@ -0,0 +1,23 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
[Q]
I am not very familiar with the server component.
Is it OK without 'use clinet' if I don't have state?
There was a problem hiding this comment.
If useState is not used, you don't need to write 'use client', but it is safer to write it because this component may have state in the future.
| @@ -5,7 +5,7 @@ import type { ElementType, FC, ReactNode } from 'react'; | |||
|
|
|||
| type Props = { | |||
| children: ReactNode; | |||
| as?: ElementType<{ className?: string; children: ReactNode }> | 'label' | 'legend' | 'p'; | |||
There was a problem hiding this comment.
Deleted because I want XXXGroup to be used instead of Label.
| @@ -25,7 +25,7 @@ type Props = Omit<React.InputHTMLAttributes<HTMLInputElement>, 'name' | 'value' | |||
|
|
|||
| /** | |||
| * アクセシビリティに配慮したラジオボタン。 | |||
| * TimeQuestionContentのような、選択した後自動で遷移しないタイプのラジオボタン（選択してもなにもおきないボタン）に使用する。 | |||
| * 選択した後自動で遷移しないタイプのラジオボタン（選択してもなにもおきないボタン）に使用 | |||
There was a problem hiding this comment.
TimeQuestionContent refers to individual product components.
| @@ -68,12 +67,15 @@ export const InputGroup: StoryObj = { | |||
| {option} | |||
| </RadioButton> | |||
| ))} | |||
| </RadioGroup> | |||
|
|
|||
| <Stack spacing="xs"> | |||
There was a problem hiding this comment.
Error messages and helper text may be implemented as RadioGroup props.
However, since it would not be consistent with the other fields, we will skip it this time.
Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>
takanorip
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Screenshot
RadioGroup With RadioButtons
RadioGroup With RadioButtons (Horizontally)
RadioGroup With RadioCard
RadioGroup With RadioCard (Horizontally)
CheckboxGroup With Checkbox
CheckboxGroup With Checkbox (Horizontally)