New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Text Component #61

Merged

takanorip merged 2 commits into ubie-oss:main from 8845musign:improve-text

Apr 15, 2024

Contributor

8845musign commented Apr 15, 2024

Overview

delete className prop
add `id prop
-Might be used in aria-* attribute
weight defaults to normal
- In rare cases, there are cases where you want to treat hx elements as normal (for structural reasons)

8845musign added 2 commits

April 15, 2024 22:15


          delete className & add id prop

4ecde2d

Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>


          Set font-weight to normal even for hx elements

febe83a

Signed-off-by: 8845musign <hiroki.yokouchi@dr-ubie.com>

8845musign self-assigned this

8845musign requested a review from takanorip as a code owner

April 15, 2024 13:22

takanorip approved these changes

View reviewed changes

takanorip merged commit ec280d2 into ubie-oss:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet