Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text align prop to <Box> and <Text> #84

Merged
merged 5 commits into from
May 14, 2024
Merged

Add text align prop to <Box> and <Text> #84

merged 5 commits into from
May 14, 2024
+78 −9

Conversation

8845musign
Copy link
Contributor

@8845musign 8845musign commented May 13, 2024 •
edited
Loading

Motivation

  • I want to specify align as a text setting
  • I want to implement the same prop as for heading in other components

Screenshots

<Box>

スクリーンショット 2024-05-13 11 12 25

<Text>

スクリーンショット 2024-05-13 11 12 38

8845musign added 5 commits May 13, 2024 10:58
@8845musign
Add text-align prop
404e574 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
fix prop comment
014a9db 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
improve story
961b20c 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
fix format
916f7ea 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign
fix story name
e01203a 
Signed-off-by: hiroki.yokouchi <hiroki.yokouchi@dr-ubie.com>
@8845musign 8845musign self-assigned this May 13, 2024
@8845musign 8845musign marked this pull request as ready for review May 13, 2024 02:13
@8845musign 8845musign requested a review from takanorip as a code owner May 13, 2024 02:13
@takanorip takanorip merged commit 1c680f4 into ubie-oss:main May 14, 2024
2 checks passed
@8845musign 8845musign deleted the add-text-align-props branch June 14, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip