fix(Geosuggest): fix accessibility #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @yfr any chance we could give the accessibility PR's a quick look ? ;) Would be great thank you! |
plumdumpling
approved these changes
Aug 3, 2023
|
Hey @plumdumpling! Thanks a lot for finally merge this fix! Any chance you could release the accessibility fix with a patch version? |
|
Hey @fcabreraupgrade! We would like to release the fix together with some more fixes and smaller updates. We're planning to have a new release ready this week. |
|
@fcabreraupgrade we released a new version including this fix under our organization scope @ubilabs/react-geosuggest and will continue there from now on. |
|
@plumdumpling thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an accessibility with the current solution
Checklist
Fixes :