fix: avoid built-ins

[Keyrxng]

Resolves #31

• Built an exclusion list based on object prototype built-ins

QA:

• difficult to QA in a working sense other than below

(async () => {
  const wordScoreCommentDetails: { [key: string]: Decimal } = {};
  const words = ["hasOwnProperty", "valueOf", "was", "async", "but", "the", "constructor", "isn", "t", "I", "was"];
  const ZERO = new Decimal(0);

  const builtIns = new Set(
    Object.getOwnPropertyNames(Object.prototype).filter((name) => typeof Object.prototype[name] === "function")
  );

  for (const word of words) {
    if (!builtIns.has(word)) {
      let counter = wordScoreCommentDetails[word] || ZERO;
      wordScoreCommentDetails[word] = counter;
    }
  }

  console.log("scoringDetails: ", wordScoreCommentDetails);
})().catch(console.error);

[0x4007]

You can definitely include my.ts as a jest test. Just name it the same as the filename like *.test.ts

[molecula451]

the only viable way i'd see testing this in a production like env is keyring setting up basically everything from scratch which would take more time than what the fix should be accomplished

I would merge this a HOT-fix to check the reproduction, it doesn't do then a revert back pretty much won't break any other stuff, i recall originally pavlovcik asked a core dev to have a test env for similar situations but not sure if it was built

[0x4007]

This doesn't make sense to me. was is not a built in property so why is it's count 0 if it's in your test array?

[Keyrxng]

because the in the test I've simplified the logic down to the core issue and removed all of the actual scoring, so it's set as zero by default. All of the built-ins are removed from the array of words

const counter = wordScoreCommentDetails[word] || ZERO;

[0x4007]

I don't understand but based on the non test code changes, and moleculas recommendation I can merge this pull

[molecula451]

ZERO it's still constructed as a Decimal, can you perhaps so it's expect a decimal in the end, can you perhaps type let counter: Decimal and test as such?

[0x4007]

Good observation

[Keyrxng]

const counter: Decimal

It's already inferred as such without being explicit but the test still passes either way, I have just tried locally but with the PR being closed it's a dud.

Proved to be working via rpc-handler anyway happy days

[molecula451]

perhaps for a future improved, pavlovick is one of the like loves everything Typed!