feat: add the permit-generator github action #69

hhio618 · 2024-09-15T17:00:37Z

Resolves #68

hhio618 · 2024-09-15T17:02:49Z

.github/workflows/permit-generator.yml

+            USERNAME=$(echo $user_amount | jq -r 'keys[0]')
+            AMOUNT=$(echo $user_amount | jq -r '.[]')
+
+            # TODO: This will convert the username to it's unique user ID.


Is this desired to be in here?

We should save user id for audit/accounting reasons. It's confusing if they change their username and that's all we store

.github/workflows/permit-generator.yml

hhio618 · 2024-09-19T09:00:54Z

@0x4007 This task looks off to me. If there's no progress soon, I discontinue my work here on this PR.

0x4007 · 2024-09-23T14:04:14Z

Can you post QA to prove it's working

0x4007 · 2024-09-30T07:44:48Z

@whilefoo @rndquu @gentlementlegen I don't recall who worked on the NFT minting part but the tests are failing due to it, and it doesn't seem like any changes related to it were made in this pull.

0x4007

Is the UUID being used? Otherwise everything looks fine @whilefoo rfc

hhio618 · 2024-10-15T15:15:38Z

Latest QA

Github action run#11348946725

Generated output:

W3sidG9rZW5UeXBlIjoiRVJDMjAiLCJ0b2tlbkFkZHJlc3MiOiIweGU5MWQxNTNlMGI0MTUxOGEyY2U4ZGQzZDc5NDRmYTg2MzQ2M2E5N2QiLCJiZW5lZmljaWFyeSI6IjB4NjMyMTI4NkY5QjczZjQyN0M3MmUxZjlGMWJDNmIzZDI1ZUYwNjYwNSIsIm5vbmNlIjoiMTE3MTAxNzE4NTUwNjA4NTI0NzQyODgxNTg5NDQ3MzY3Mjc1ODc2MjY4Nzk0NDc5MDQwMjMwOTI5MDQzOTkyNjUxNDMzNjM4OTIyMDUiLCJkZWFkbGluZSI6IjExNTc5MjA4OTIzNzMxNjE5NTQyMzU3MDk4NTAwODY4NzkwNzg1MzI2OTk4NDY2NTY0MDU2NDAzOTQ1NzU4NDAwNzkxMzEyOTYzOTkzNSIsImFtb3VudCI6IjIwMDAwMDAwMDAwMDAwMDAwMDAwMCIsIm93bmVyIjoiMHhmMzlGZDZlNTFhYWQ4OEY2RjRjZTZhQjg4MjcyNzljZmZGYjkyMjY2Iiwic2lnbmF0dXJlIjoiMHhmM2MwNDViZTEzMTU4MTJkMmQyYmVlZDdmOGQ0YWZlOTQwODU4NTg4YTBiZTdjNjlkZWM4MWI0MThjMzkxOWExMmY2NDE5YTUxZTJkMzIyZDJhMGVjZmI2ZTkyMTdhYzBlMTcwM2RkNjhhZGE0N2ZhMzcxZTNlODQzYTRmNWQxNzFjIiwibmV0d29ya0lkIjoxMDB9XQ==

gentlementlegen · 2024-10-15T19:02:04Z

Technical question: I was reading the related spec and it states:

This should be the only way to generate permits in our system, so that we can enforce capturing value from plugin developers.

So it would mean that https://github.com/ubiquity-os-marketplace/text-conversation-rewards for example should be using this instead of generating permits on its own. It could eventually call this Action, but workers are not instantaneous and the end of the workflow should be awaited somewhere. In the case of a Worker that would eventually need to generate a permit, I don't see how this could be called either. Wouldn't it make more sense to have this as an endpoint? I understand this is a long running task which is why it was designed as an Action, but seems tricky to use in a real-case scenario.

whilefoo · 2024-10-15T18:41:39Z

scripts/github-action-permit-generator.ts

+  context.adapters = createAdapters(supabaseClient, context);
+
+  const permits = await generatePayoutPermit(context, config.permitRequests);
+  await returnDataToKernel(env.GITHUB_TOKEN, "todo_state", permits);


not sure why you are returning data to kernel if this workflow is manually triggered by someone

I initially thought it was meant to be part of the process. Should I remove it?

Because this script is only called manually and not by the kernel

whilefoo · 2024-10-15T18:42:22Z

src/handlers/generate-erc20-permit.ts

@@ -54,6 +55,8 @@ export async function generateErc20PermitSignature(
      issueNodeId = contextOrPayload.payload.issue.node_id;
    } else if ("pull_request" in contextOrPayload.payload) {
      issueNodeId = contextOrPayload.payload.pull_request.node_id;
+    } else if (contextOrPayload.config.runId) {


Suggested change

} else if (contextOrPayload.config.runId) {

} else {

Thanks for the review, removed.

whilefoo · 2024-10-15T18:42:37Z

scripts/github-action-permit-generator.ts

+    evmNetworkId: Number(env.EVM_NETWORK_ID),
+    evmPrivateEncrypted: env.EVM_PRIVATE_KEY,
+    permitRequests: permitRequests,
+    runId: runId,


Suggested change

runId: runId,

whilefoo · 2024-10-15T19:41:01Z

src/types/env.ts

+  EVM_NETWORK_ID: T.Optional(T.String()),
+  EVM_PRIVATE_KEY: T.Optional(T.String()),
+  EVM_TOKEN_ADDRESS: T.Optional(T.String()),
+  PAYMENT_REQUESTS: T.Optional(T.String()),


I wonder if there's a way to avoid cluttering the env just for this Action, maybe through CLI?

Certainly, I've taken care of that in the following commits.

0x4007 · 2024-10-16T04:41:57Z

I understand this is a long running task which is why it was designed as an Action, but seems tricky to use in a real-case scenario.

I dont think this needs to be long running. So it makes sense to make an API endpoint hosted on Cloudflare Workers.

hhio618 · 2024-10-16T14:54:14Z

Latest QA

Github action run#11379446214

Output:

W3sidG9rZW5UeXBlIjoiRVJDMjAiLCJ0b2tlbkFkZHJlc3MiOiIweGU5MWQxNTNlMGI0MTUxOGEyY2U4ZGQzZDc5NDRmYTg2MzQ2M2E5N2QiLCJiZW5lZmljaWFyeSI6IjB4NjMyMTI4NkY5QjczZjQyN0M3MmUxZjlGMWJDNmIzZDI1ZUYwNjYwNSIsIm5vbmNlIjoiNzY1OTI2OTEzNjcyMjY0NDcxNjk2NzA2NDQ1MTk2MDM0ODA3ODExMDY1Nzc2MzMxMjMwNjkyNjM5NzcyODk2NzQwMDk2MDA2Mjc0ODIiLCJkZWFkbGluZSI6IjExNTc5MjA4OTIzNzMxNjE5NTQyMzU3MDk4NTAwODY4NzkwNzg1MzI2OTk4NDY2NTY0MDU2NDAzOTQ1NzU4NDAwNzkxMzEyOTYzOTkzNSIsImFtb3VudCI6IjIwMDAwMDAwMDAwMDAwMDAwMDAwMCIsIm93bmVyIjoiMHhmMzlGZDZlNTFhYWQ4OEY2RjRjZTZhQjg4MjcyNzljZmZGYjkyMjY2Iiwic2lnbmF0dXJlIjoiMHhiNmY2NjA5YjRiOGI4ZjViMjYwZDRhODc4ZmIyY2FlYzk2MjMwZWJmNDlmZmVhZjVkNzZkNDRiMjYxYmZhZjM1MjUxYzIxM2RkNTdhNmFhMjU1MDlhMGUwZmQxYTcxNDBjOTcyOTVjM2U0MDk4YzYzZjE0ZWVlZjhjYjc3NzQ2YTFjIiwibmV0d29ya0lkIjoxMDB9XQ==

0x4007 · 2024-10-20T18:37:55Z

What about the footer config code?

rndquu · 2024-10-21T16:03:08Z

I think in order to save time we should:

Close this PR (because many changes are incompatible with the cloudflare worker code)
Close Convert to "Plugin" #68 as completed
Proceed straight to Convert plugin to cloudflare worker #92

rndquu · 2024-10-21T16:03:43Z

What about the footer config code?

The actual comment is posted via https://github.com/ubiquity-os-marketplace/text-conversation-rewards, https://github.com/ubiquity-os/permit-generation is responsible solely for permits

hhio618 · 2024-10-22T17:03:06Z

What about the footer config code?

Could you please provide more details or specifications for this task?

0x4007 · 2024-10-22T20:48:01Z

It's in the middle of the spec. But maybe it makes sense to scope this for only the reward amounts to be returned

feat: add the permit-generator github action

25932b2

hhio618 force-pushed the development branch from e6d8d43 to 25932b2 Compare September 15, 2024 17:01

hhio618 commented Sep 15, 2024

View reviewed changes

.github/workflows/permit-generator.yml Outdated Show resolved Hide resolved

0x4007 mentioned this pull request Sep 23, 2024

Permit Request Authentication #71

Open

hhio618 added 5 commits September 23, 2024 22:08

feat: add permit-generator script [WIP]

f0b5b9d

feat: add the permit-generator script

36e3245

feat: post permits to github issues

b2038b0

fix: few adjustments

c3b3c8d

fix: add missing envs

798aa5c

hhio618 force-pushed the development branch 7 times, most recently from 848738c to 2159e3e Compare September 29, 2024 19:03

hhio618 force-pushed the development branch from 2159e3e to c476b5f Compare September 30, 2024 11:44

cohow and others added 9 commits September 30, 2024 15:17

refactor: downgrade to ethers@v5

e397fe0

fix: add yarnrc file back

787979f

chore: change yarn version

2e61614

chore: remove packageManager

ba0d046

fix: remove the env decoder

a225135

fix: type/typo fix

f926e74

chore: add logs

1620035

fix: extend context env type

0ac5357

refactor: switch over action core lib

917ae26

0x4007 mentioned this pull request Oct 12, 2024

Optional NFT Types #88

Open

hhio618 requested a review from 0x4007 October 14, 2024 14:59

0x4007 approved these changes Oct 14, 2024

View reviewed changes

hhio618 added 5 commits October 14, 2024 20:26

feat: use uuid for nonce

99d2feb

chore: fix knip

8e5cd8f

chore: add @types/uuid

4aadfc4

chore: cleanup

2db0505

chore: fix format:cspell

ff0d9d9

whilefoo suggested changes Oct 15, 2024

View reviewed changes

refactor: remove runId

5b20c35

hhio618 force-pushed the development branch from 5e863f0 to 4b03f8a Compare October 16, 2024 08:11

refactor: simplify the env vars

c22e4c2

hhio618 force-pushed the development branch from 4b03f8a to c22e4c2 Compare October 16, 2024 14:52

refactor: rem return to kernel

c78613a

hhio618 requested a review from whilefoo October 17, 2024 06:23

hhio618 added 2 commits October 17, 2024 09:56

Merge branch 'ubiquity-os:development' into development

9fe5fda

chore: cleanup

fe3e60a

hhio618 requested a review from 0x4007 October 19, 2024 05:56

0x4007 mentioned this pull request Oct 21, 2024

Optional NFT Types #90

Open

rndquu mentioned this pull request Oct 21, 2024

Convert plugin to cloudflare worker #92

Open

0x4007 closed this Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add the permit-generator github action #69

feat: add the permit-generator github action #69

hhio618 commented Sep 15, 2024

hhio618 Sep 15, 2024

0x4007 Sep 23, 2024

hhio618 commented Sep 19, 2024

0x4007 commented Sep 23, 2024

0x4007 commented Sep 30, 2024

0x4007 left a comment

hhio618 commented Oct 15, 2024

gentlementlegen commented Oct 15, 2024

whilefoo Oct 15, 2024

hhio618 Oct 16, 2024

whilefoo Oct 16, 2024

whilefoo Oct 15, 2024

hhio618 Oct 16, 2024

whilefoo Oct 15, 2024

hhio618 Oct 16, 2024

whilefoo Oct 15, 2024

hhio618 Oct 16, 2024

0x4007 commented Oct 16, 2024

hhio618 commented Oct 16, 2024 •

edited

Loading

0x4007 commented Oct 20, 2024

rndquu commented Oct 21, 2024

rndquu commented Oct 21, 2024

hhio618 commented Oct 22, 2024

0x4007 commented Oct 22, 2024 •

edited

Loading

feat: add the permit-generator github action #69

feat: add the permit-generator github action #69

Conversation

hhio618 commented Sep 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hhio618 commented Sep 19, 2024

0x4007 commented Sep 23, 2024

0x4007 commented Sep 30, 2024

0x4007 left a comment

Choose a reason for hiding this comment

hhio618 commented Oct 15, 2024

Latest QA

gentlementlegen commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x4007 commented Oct 16, 2024

hhio618 commented Oct 16, 2024 • edited Loading

Latest QA

0x4007 commented Oct 20, 2024

rndquu commented Oct 21, 2024

rndquu commented Oct 21, 2024

hhio618 commented Oct 22, 2024

0x4007 commented Oct 22, 2024 • edited Loading

hhio618 commented Oct 16, 2024 •

edited

Loading

0x4007 commented Oct 22, 2024 •

edited

Loading