Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/workerize #96

Open
wants to merge 150 commits into
base: development
Choose a base branch
from
Open

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Oct 30, 2024

Resolves #92

@gentlementlegen
Copy link
Member

@Keyrxng Since you switched to bun could you upgrade to the latest version and change the lockb to lock

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 27, 2025

@Keyrxng Since you switched to bun could you upgrade to the latest version and change the lockb to lock

Done buddy ty for the review

@whilefoo
Copy link
Member

this is still backward-compatible, right? just the function signature changed (no more context, just permit requests), so we can keep using it as a library until everything is ready

@Keyrxng

This comment was marked as resolved.

@Keyrxng

This comment was marked as off-topic.

@Keyrxng

This comment was marked as off-topic.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 28, 2025

Marked as off-topic because I was forward thinking things instead rather than for the npm package, my bad.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 28, 2025

PermitRequests previously sent username instead of user.id. We can either update the invoker or I can revert that change and fetch their GH ID?

This is the only important sentence to address before we can merge this and address the other problems in a separate PR

const { type, amount, username, contributionType, tokenAddress } = permitRequest;

this is still backward-compatible, right? just the function signature changed (no more context, just permit requests), so we can keep using it as a library until everything is ready

We could release a new major and we'd be safe no matter what I'm sure, I figured that's what we'd be doing.

@whilefoo
Copy link
Member

whilefoo commented Mar 1, 2025

PermitRequests previously sent username instead of user.id. We can either update the invoker or I can revert that change and fetch their GH ID?

I think user id and wallet address should be passed in because we already fetch wallet address in text-conversation-rewards so it doesn't make sense to do it twice. permit-generation should be minimalistic and only focus on generating permits

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Mar 2, 2025

I'm assuming you are talking about in regards to the npm package, but once permit generation is centralized to the worker I assume that it will be responsible for the user checks and pushing to the DB?

Kept userId and added userWalletAddress so we will need to update text-conversation.

I haven't touched the encode/decode methods or the types associated with them because that would break pay.ubq I'm sure so that can be left until the worker is rolled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert plugin to cloudflare worker
6 participants