-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/workerize #96
base: development
Are you sure you want to change the base?
Feat/workerize #96
Conversation
Template init
…t-config feat: updated eslint to use flat-config file
…ize version metadata
@Keyrxng Since you switched to bun could you upgrade to the latest version and change the |
Done buddy ty for the review |
this is still backward-compatible, right? just the function signature changed (no more context, just permit requests), so we can keep using it as a library until everything is ready |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Marked as off-topic because I was forward thinking things instead rather than for the npm package, my bad. |
…ility with PermitRequest
…er for improved clarity and consistency
This is the only important sentence to address before we can merge this and address the other problems in a separate PR
We could release a new major and we'd be safe no matter what I'm sure, I figured that's what we'd be doing. |
I think user id and wallet address should be passed in because we already fetch wallet address in |
I'm assuming you are talking about in regards to the npm package, but once permit generation is centralized to the worker I assume that it will be responsible for the user checks and pushing to the DB? Kept I haven't touched the |
Resolves #92