Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: worker url #36

Merged
merged 6 commits into from
Dec 18, 2024
Merged

feat: worker url #36

merged 6 commits into from
Dec 18, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Dec 17, 2024 •
edited
Loading

0x4007
0x4007 reviewed Dec 17, 2024
View reviewed changes
@gentlementlegen gentlementlegen marked this pull request as ready for review December 17, 2024 14:03
whilefoo
whilefoo requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to make this a shared workflow so it won't become a hassle if we change any of the code

@gentlementlegen gentlementlegen marked this pull request as draft December 17, 2024 17:26
@gentlementlegen gentlementlegen marked this pull request as ready for review December 18, 2024 08:14
@gentlementlegen gentlementlegen merged commit 6031714 into ubiquity-os:development Dec 18, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/worker-url branch December 18, 2024 10:38
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

@0x4007 0x4007 Awaiting requested review from 0x4007

@whilefoo whilefoo Awaiting requested review from whilefoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add url property to manifest.json
4 participants
@gentlementlegen @0x4007 @rndquu @whilefoo